fs: validate writev fds consistently#29185
Merged
cjihrig merged 1 commit intonodejs:masterfrom Aug 19, 2019
Merged
Conversation
nodejs-github-bot
added
the
fs
Trott
approved these changes
Aug 17, 2019
lpinca
approved these changes
Aug 17, 2019
addaleax
approved these changes
Aug 17, 2019
jasnell
approved these changes
Aug 18, 2019
Collaborator
ZYSzys
approved these changes
Aug 18, 2019
ZYSzys
added
the
author ready
gengjiawen
approved these changes
Aug 18, 2019
antsmartian
approved these changes
Aug 18, 2019
Collaborator
trivikr
approved these changes
Aug 18, 2019
Collaborator
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/25096/ EDIT: CI was yellow. |
This commit updates the recently added writev methods to validate file descriptors like the other fs methods do. PR-URL: nodejs#29185 Refs: nodejs#25925 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 20, 2019
This commit updates the recently added writev methods to validate file descriptors like the other fs methods do. PR-URL: #29185 Refs: #25925 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the recently added writev methods to validate file descriptors like the other fs methods do.
Refs: #25925
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes